public changes for passkey support #11546
Conversation
Generated by 🚫 Danger |
Apple API Diff ReportCommit: 110b526 FirebaseAuthClassesFIRUser[ADDED] -startPasskeyEnrollmentWithName:completion:Swift:
+ func startPasskeyEnrollment ( with name : String ?) async throws -> UnsafeMutablePointer < Int32 >
Objective-C:
+ - ( void ) startPasskeyEnrollmentWithName :( nullable NSString * ) name completion :( nullable void ( ^ )( int * _Nullable , NSError * _Nullable )) completion ;[ADDED] enrolledPasskeysSwift:
+ var enrolledPasskeys : [ PasskeyInfo ] { get }
Objective-C:
+ @property ( nonatomic , readonly ) API_UNAVAILABLE ( watchos ) NSArray < FIRPasskeyInfo *> * enrolledPasskeys ;[ADDED] -finalizePasskeyEnrollmentWithPlatformCredential:completion:Swift:
+ func finalizePasskeyEnrollment ( with platformCredential : Any ! ) async throws -> AuthDataResult
Objective-C:
+ - ( void ) finalizePasskeyEnrollmentWithPlatformCredential :( id ) platformCredential completion : ( nullable void ( ^ )( FIRAuthDataResult * _Nullable , NSError * _Nullable )) completion ;[ADDED] -unenrollPasskeyWithCredentialID:completion:Swift:
+ func unenrollPasskey ( with credentialID : String ) async throws
Objective-C:
+ - ( void ) unenrollPasskeyWithCredentialID :( nonnull NSString * ) credentialID completion :( nullable void ( ^ )( NSError * _Nullable )) completion ;[ADDED] FIRPasskeyInfo[ADDED] FIRPasskeyInfoSwift:
+ class PasskeyInfo : NSObject
+ var name : String { get }
+ var credentialID : String { get }
Objective-C:
+ @interface FIRPasskeyInfo : NSObject
+ @property ( nonatomic , readonly ) NSString * _Nonnull name ;
+ @property ( nonatomic , readonly ) NSString * _Nonnull credentialID ;FIRAuth[ADDED] -startPasskeySignInWithCompletion:Swift:
+ func startPasskeySignIn () async throws -> UnsafeMutablePointer < Int32 >
Objective-C:
+ - ( void ) startPasskeySignInWithCompletion : ( nullable void ( ^ )( int * _Nullable , NSError * _Nullable )) completion ;[ADDED] -finalizePasskeySignInWithPlatformCredential:completion:Swift:
+ func finalizePasskeySignIn ( with platformCredential : Any ! ) async throws -> FIRAuthDataResult
Objective-C:
+ - ( void ) finalizePasskeySignInWithPlatformCredential :( id ) platformCredential completion : ( nullable void ( ^ )( FIRAuthDataResult * _Nullable , NSError * _Nullable )) completion ; |
|
will this PR address #11548? |
| @@ -17,6 +17,7 @@ | |||
| #import <AvailabilityMacros.h> | |||
| #import <Foundation/Foundation.h> | |||
|
|
|||
| #import <AuthenticationServices/AuthenticationServices.h> | |||
There was a problem hiding this comment.
@paulb777, should types from this framework instead be forward declared within the header?
There was a problem hiding this comment.
Yes, and wrapped in #if TARGET_OS_IOS
There was a problem hiding this comment.
can you elaborate on the forward declaration part?
another question on TARGET_OS_IOS, these APIs will run on mac os, ios and tv os (but not watch OS).
I was thinking using
if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_MAC. However going thru this doc, I have the assumption that TARGET_OS_MAC will include all IOS, TVOS and WATCHOS, can you suggest?
There was a problem hiding this comment.
can you elaborate on the forward declaration part?
So line 20 should be moved to the implementation file. And in its place should be forward declarations for the types used from the AuthenticationServices module. The diff should look like:
| #import <AuthenticationServices/AuthenticationServices.h> | |
| @class ASAuthorizationPlatformPublicKeyCredentialAssertion; | |
| @class ASAuthorizationPlatformPublicKeyCredentialAssertionRequest; |
another question on TARGET_OS_IOS, these APIs will run on mac os, ios and tv os (but not watch OS).
I was thinking using
if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_MAC. However going thru this doc, I have the assumption that TARGET_OS_MAC will include all IOS, TVOS and WATCHOS, can you suggest?
TARGET_OS_MAC might be too broad. Something like the following should specifically get all platforms except watchOS:
#if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_OSX || TARGET_OS_MACCATALYST
#endifThere was a problem hiding this comment.
Thank you Nick. After trying the suggestion we synced offline, it seems importing in the .m file still cause me compiler errors. Can you help me take a look where I might did wrong? (CI is also failing for the same issue)
This reverts commit 21d092d.
API proposal for passkey changes.